Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctcp fixes #118

Merged
merged 4 commits into from Aug 5, 2019
Merged

Ctcp fixes #118

merged 4 commits into from Aug 5, 2019

Conversation

theunkn0wn1
Copy link
Collaborator

This pull request adjusts several issues found in the CTCP handling library, which prevented proper handling of ctcp messages.

Validation test:

>unknown[pydle]< CTCP HI
>unknown[pydle]< CTCP HI fo
* unknown[pydle] has quit (Read error)
* unknown[pydle] (~unknownpy@674CBF4E.74FC38EB.24F6D0A2.IP) has joined
>unknown[pydle]< CTCP HI fo
* Received a CTCP HI fo from unknown[pydle]
>unknown[pydle]< CTCP HI fo fo
* Received a CTCP HI fo fo from unknown[pydle]
>unknown[pydle]< CTCP VERSION
-unknown[pydle]- VERSION pydle v0.9.1

relevent ctcp callback:

    async def on_ctcp(self, by, target, what, contents):
        print(f"on_ctcp invoked with by='{by}'\ttarget='{target}'\twhat='{what}'\tcontents = {contents}")
        await self.ctcp(by, what, contents=contents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant