Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Languages #155

Closed
c4pp4 opened this issue Sep 10, 2016 · 3 comments
Closed

Languages #155

c4pp4 opened this issue Sep 10, 2016 · 3 comments

Comments

@c4pp4
Copy link
Collaborator

c4pp4 commented Sep 10, 2016

Some corrections related to languages.

unity-base/unity-language-pack
Activity-log-manager and indicator-datetime po-files are in "language-pack-" folder instead of "language-pack-gnome-". Furthermore it should be save to add ubuntu-help po-file, because ubuntu-docs doesn't install it.
unity-language-pack.diff.txt

gnome-extra/activity-log-manager
It's looking at "//" folder instead of "/usr/share/locale". (I've also removed some useless code snippets.)
activity-log-manager.diff.txt

unity-indicators/indicator-datetime
It's looking at "/locale" folder instead of "/usr/share/locale".
indicator-datetime.diff.txt

unity-indicators/indicator-sound
It's looking at "/locale" folder instead of "/usr/share/locale".
indicator-sound.diff.txt

unity-indicators/indicator-session
_Renaming "menu, help_label" to "menu, ("Unity Help")" is not ideal, because it's not translated then.
indicator-session.diff.txt
unity.patch.txt

@c4pp4
Copy link
Collaborator Author

c4pp4 commented Sep 10, 2016

Another issue: Security & Privacy launcher in Unity Control Center will never be translated, because its po-file is separated.

There is a one solution - to use this patch from Ubuntu's glib2 package:
01_gettext-desktopfiles.patch.txt
Then you have to change activity-log-manager.ebuild with something like this:
find ${S}/data -type f -name "*.desktop.in" -exec sh -c 'echo X-GNOME-Gettext-Domain=unity-control-center >> "$1"' -- {} \;

I think all apps using unity-language-pack should have changed appropriate desktop-file.

@c4pp4
Copy link
Collaborator Author

c4pp4 commented Sep 12, 2016

I've gone through unity-gentoo repo and the following packages have an appropriate language file in unity-language-pack so we can remove them because unity-language-pack will always be more complete.

language-pack-
media-sound/pulseaudio
sys-apps/ureadahead
www-client/webbrowser-app
x11-misc/lightdm

language-pack-gnome-
app-accessibility/onboard
app-backup/deja-dup
gnome-base/nautilus
gnome-extra/activity-log-manager
gnome-extra/nm-applet
gnome-extra/polkit-gnome (polkit-gnome-1.po)
media-gfx/shotwell
media-sound/rhythmbox
net-libs/account-plugins
net-libs/gnome-online-accounts
net-libs/libsoup-gnome (libsoup.po)
sys-apps/accountsservice (accounts-service.po)
unity-base/hud
x11-libs/gtk+ (gtk20.po, gtk20-properties.po, gtk30.po, gtk30-properties.po)

In case of patching glib2 - the following packages install desktop launchers so we can add into them "X-GNOME-Gettext-Domain":
app-accessibility/onboard
app-backup/deja-dup
gnome-base/nautilus
gnome-extra/activity-log-manager
gnome-extra/nm-applet
media-gfx/shotwell
media-sound/rhythmbox
unity-base/hud
www-client/webbrowser-app

@shiznix
Copy link
Owner

shiznix commented Sep 12, 2016

All looks good, will implement something over the next couple of days - thanks :)

c4pp4 added a commit that referenced this issue Sep 16, 2016
c4pp4 added a commit that referenced this issue Sep 16, 2016
…ocale. Add gettext key to .desktop file. Remove some leftovers related to Precise.
c4pp4 added a commit that referenced this issue Sep 17, 2016
…/share/locale. Add gettext key to .desktop file. Remove some leftovers related to Precise."

This reverts commit 4b7ef28.
c4pp4 added a commit that referenced this issue Sep 17, 2016
…ocale. Add gettext key into .desktop file. Remove some leftovers related to Precise.
c4pp4 added a commit that referenced this issue Sep 17, 2016
…/share/locale. Add gettext key into .desktop file. Remove some leftovers related to Precise."

This reverts commit 0ef04e7.
c4pp4 added a commit that referenced this issue Sep 17, 2016
…ocale. Add gettext key into .desktop file. Remove some leftovers related to Precise.
c4pp4 added a commit that referenced this issue Sep 17, 2016
@c4pp4 c4pp4 closed this as completed in 32cecb3 Sep 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants