Update Dockerfile, README and add maxmind example #53
Conversation
Signed-off-by: Ivan Schaller <ivan@schaller.sh>
Dockerfile
Outdated
| && go build -o "endlessh-go" | ||
|
|
||
|
|
||
| FROM alpine:3.17 |
There was a problem hiding this comment.
We would better not to use apline in the release.
There are some article on the internet telling why.
e.g. https://martinheinz.dev/blog/92
README.md
Outdated
| @@ -33,6 +33,8 @@ Then you can try to connect to the endlessh server. Your SSH client should hang | |||
| ssh -p 2222 localhost | |||
| ``` | |||
|
|
|||
| The default container user has uid/gid 2000. | |||
There was a problem hiding this comment.
I feel this is irreverent here.
Why we need it here?
If we have to keep it, it should go to line 28.
README.md
Outdated
| @@ -83,26 +85,34 @@ Usage of ./endlessh-go | |||
| comma-separated list of pattern=N settings for file-filtered logging | |||
| ``` | |||
|
|
|||
| ## Using privileged ports (<1024) | |||
There was a problem hiding this comment.
This is a docker problem not the endlessh-go problem.
The only place I mention docker in this main README.md is line 28.
This could go to the docker example.
You cannot assume every one is using container.
You cannot assume who is using container also uses docker.
README.md
Outdated
| | endlessh_trapped_time_seconds_total | count | Total seconds clients spent on endlessh. | | ||
| | endlessh_client_open_count | count | Number of connections of clients. <br> Labels: <br> <ul><li> `ip`: IP of the client </li> <li> `country`: Country of the IP </li> <li> `location`: Country, Region, and City </li> <li> `geohash`: Geohash of the location </li></ul> | | ||
| | endlessh_client_trapped_time_seconds | count | Seconds a client spends on endlessh. <br> Labels: <br> <ul><li> `ip`: IP of the client </li></ul> | | ||
| | Metric | Type | Description | |
There was a problem hiding this comment.
Which editor are you using?
I don't thin we need the extra space at the end to align each line.
| @@ -0,0 +1,36 @@ | |||
| version: "3" | |||
Signed-off-by: Ivan Schaller <ivan@schaller.sh>
|
Updated the PR |
Hi, this PR does the following:
If you have any questions or comments, just tell me.
Best regards,
Ivan