Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infection and update to PHPUnit 11 #32

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 19, 2024

Infection has become a somewhat useful tool, but one mostly ignored in the project.

On the other hand, when it fails due to low MSI, it usually leads to reducing required MSI and going on.

Additionally, it usually delays adopting new PHPUnit major versions, due to overlapping dependencies with mismatching versions.

This PR removes infection all together, and updates to PHPUnit 11

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a43b380) 72.61% compared to head (d999601) 72.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
- Coverage     72.61%   72.28%   -0.33%     
  Complexity       22       22              
============================================
  Files             5        5              
  Lines            84       83       -1     
============================================
- Hits             61       60       -1     
  Misses           23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 0e7a1b9 into shlinkio:main Feb 19, 2024
8 of 9 checks passed
@acelaya acelaya deleted the feature/phpunit-11 branch February 19, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant