build: switch nginx docker base image to unprivileged version

[aschaber1]

Hello,

I switched the base image from nginx (privileged) to nginx unprivileged. Also updated the nginx config and README.

Looking forward to your feedback.

[github-actions]

Preview environment

https://shlinkio.github.io/shlink-web-client/unpriv-container/

[acelaya]

Thanks!

I'm generally in favor of not running the image as root, but I added some questions before going forward.

EDIT: Also, please rebase when you have a minute. I merged some dependabot PRs and there seems to have some conflicts now.

[aschaber1]

Hello, thanks for looking into this. I tried to give more insights to the changes. Please let me know if there are any more questions I can help with.

I'll rebase it later this weekend.

[acelaya]

Thanks @aschaber1. I'm ok going forward with this, just make sure you rebase from develop and remove the hardcoded registry names.

After that I will test the image and merge it if everything goes right.

[aschaber1]

Hello @acelaya, I just pushed the updated commit. Did the updates in terms of registry as you suggested. Let me know, if there's something else I can do :)

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (3c4fa33) 86.61% compared to head (7eae695) 86.61%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #902   +/-   ##
========================================
  Coverage    86.61%   86.61%           
========================================
  Files           54       54           
  Lines         2226     2226           
  Branches       291      291           
========================================
  Hits          1928     1928           
  Misses           8        8           
  Partials       290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aschaber1]

@acelaya I found this blog post from Red Hat regarding using shortnames, and how it might also break things.

https://www.redhat.com/sysadmin/container-image-short-names