Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show shortlink on Non-orphan visits list. #244

Closed
gcarrarom opened this issue May 8, 2023 · 8 comments · Fixed by #329
Closed

Show shortlink on Non-orphan visits list. #244

gcarrarom opened this issue May 8, 2023 · 8 comments · Fixed by #329
Labels
bug Something isn't working
Milestone

Comments

@gcarrarom
Copy link

Summary

When visiting the Non-orphan visits view, I can't find which shortlink was the one visited. I would like to have an entry at the table showing which shortlink was visited. Here's a suggestion of what this could look like:
CleanShot 2023-05-08 at 16 24 07

This could potentially be showing the labels or even just a link to the shortlink page.

@acelaya
Copy link
Member

acelaya commented May 9, 2023

Requires shlinkio/shlink#1330

@acelaya acelaya added the blocked label May 9, 2023
@acelaya acelaya transferred this issue from shlinkio/shlink-web-client Feb 2, 2024
@acelaya acelaya removed the blocked label Apr 14, 2024
@ejohb
Copy link

ejohb commented Apr 14, 2024

Thanks for your work on this!

I've updated, but still can't see the shortlink in non-orphan-visits/list. Do I need to do anything to enable it?

Server: v4.1.0 - Client: v4.1.1

@acelaya
Copy link
Member

acelaya commented Apr 14, 2024

I've updated, but still can't see the shortlink in non-orphan-visits/list

This issue is still not implemented 😅

It's just unblocked now, because the backend now returns all required info.

@ejohb
Copy link

ejohb commented Apr 14, 2024

Oh, I'd misunderstood. Thanks for explaining!

@acelaya
Copy link
Member

acelaya commented Apr 16, 2024

I'm going to treat this as a bug, as in "the server is returning the information, but the client is using the wrong logic to determine when to show it, resulting in the info not being displayed"

@acelaya acelaya added bug Something isn't working and removed feature labels Apr 16, 2024
@acelaya acelaya added this to the 0.6.2 milestone Apr 16, 2024
@acelaya
Copy link
Member

acelaya commented Apr 17, 2024

This is now implemented. I just need to fix one last bug, and then I'll release the fixes with shlink-web-client 4.1.2

@acelaya
Copy link
Member

acelaya commented Apr 17, 2024

I have just released shlink-web-client 4.1.2, which includes this.

As long as the server is Shlink >=4.1, all kinds of visits will now show the visited URL column in the visits table.

@ejohb
Copy link

ejohb commented Apr 17, 2024

Works great. Thanks so much for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants