Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display visited URL for regular visits #329

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Apr 17, 2024

Closes #244

Ensure the visited URL is displayed for any kind of visit, if the server returned it.

Up until now, this was displayed only for orphan visits.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.92%. Comparing base (e21c4d6) to head (776f36d).
Report is 7 commits behind head on main.

❗ Current head 776f36d differs from pull request most recent head 9723703. Consider uploading reports for the commit 9723703 to get more accurate results

Files Patch % Lines
src/visits/VisitsTable.tsx 57.14% 0 Missing and 3 partials ⚠️
src/visits/services/VisitsParser.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   84.93%   84.92%   -0.01%     
==========================================
  Files         159      159              
  Lines        9915     9913       -2     
  Branches     1370     1370              
==========================================
- Hits         8421     8419       -2     
  Misses        150      150              
  Partials     1344     1344              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 8025f30 into shlinkio:main Apr 17, 2024
5 checks passed
@acelaya acelaya deleted the feature/regular-visited-url branch April 17, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show shortlink on Non-orphan visits list.
1 participant