Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comments and API for createLoadVisits helper #184

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 30, 2023

Part of #7

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (7a7a181) 79.24% compared to head (8988112) 79.26%.

Files Patch % Lines
src/visits/reducers/common/createLoadVisits.ts 86.20% 0 Missing and 4 partials ⚠️
...c/visits/reducers/common/createVisitsAsyncThunk.ts 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   79.24%   79.26%   +0.02%     
==========================================
  Files         157      157              
  Lines        8981     8991      +10     
  Branches     1146     1146              
==========================================
+ Hits         7117     7127      +10     
  Misses        743      743              
  Partials     1121     1121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 8698c31 into shlinkio:main Dec 30, 2023
7 checks passed
@acelaya acelaya deleted the feature/improve-comments branch December 30, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant