Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/url visits comparison #205

Merged
merged 5 commits into from
Jan 14, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 14, 2024

Part of #7

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (1db4725) 79.06% compared to head (4ed0cbf) 83.92%.
Report is 16 commits behind head on main.

Files Patch % Lines
...its/visits-comparison/ShortUrlVisitsComparison.tsx 83.58% 0 Missing and 11 partials ⚠️
...ts-comparison/reducers/shortUrlVisitsComparison.ts 88.88% 0 Missing and 5 partials ⚠️
src/short-urls/helpers/index.ts 71.42% 0 Missing and 2 partials ⚠️
...c/visits/visits-comparison/TagVisitsComparison.tsx 60.00% 0 Missing and 2 partials ⚠️
src/utils/helpers/hooks.ts 88.88% 0 Missing and 1 partial ⚠️
...isits/visits-comparison/DomainVisitsComparison.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   79.06%   83.92%   +4.86%     
==========================================
  Files         167      158       -9     
  Lines        9494     9047     -447     
  Branches     1192     1194       +2     
==========================================
+ Hits         7506     7593      +87     
+ Misses        822      288     -534     
  Partials     1166     1166              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/url-visits-comparison branch from 2e46941 to 87406d7 Compare January 14, 2024 11:25
@acelaya acelaya marked this pull request as ready for review January 14, 2024 12:08
@acelaya acelaya merged commit a23fe79 into shlinkio:main Jan 14, 2024
5 checks passed
@acelaya acelaya deleted the feature/url-visits-comparison branch January 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant