Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/visits comparison limit #206

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 15, 2024

Part of #7

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a23fe79) 83.91% compared to head (0d5c44f) 83.92%.

Files Patch % Lines
...isits/visits-comparison/VisitsComparisonContext.ts 75.00% 0 Missing and 3 partials ⚠️
...ts/visits-comparison/VisitsComparisonCollector.tsx 77.77% 0 Missing and 2 partials ⚠️
src/domains/helpers/DomainDropdown.tsx 0.00% 0 Missing and 1 partial ⚠️
src/tags/TagsTableRow.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   83.91%   83.92%           
=======================================
  Files         158      158           
  Lines        9047     9057   +10     
  Branches     1193     1194    +1     
=======================================
+ Hits         7592     7601    +9     
  Misses        288      288           
- Partials     1167     1168    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit b04eaf7 into shlinkio:main Jan 15, 2024
5 of 7 checks passed
@acelaya acelaya deleted the feature/visits-comparison-limit branch January 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant