Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe visits comparisons components to mercure hub #207

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Jan 16, 2024

Closes #7

Make all visits-comparison components subscribe to the visits mercure topic, and their reducers enhance visits groups via createNewVisits action.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Comparison is base (b04eaf7) 83.92% compared to head (b9eacf5) 83.73%.

❗ Current head b9eacf5 differs from pull request most recent head 07f84b9. Consider uploading reports for the commit 07f84b9 to get more accurate results

Files Patch % Lines
...n/reducers/common/createVisitsComparisonReducer.ts 48.00% 12 Missing and 1 partial ⚠️
src/visits/types/helpers.ts 85.10% 0 Missing and 7 partials ⚠️
src/visits/reducers/types/index.ts 0.00% 4 Missing and 1 partial ⚠️
...sits-comparison/reducers/domainVisitsComparison.ts 33.33% 4 Missing ⚠️
...ts-comparison/reducers/shortUrlVisitsComparison.ts 42.85% 4 Missing ⚠️
.../visits-comparison/reducers/tagVisitsComparison.ts 33.33% 4 Missing ⚠️
src/visits/visits-comparison/reducers/types.ts 0.00% 4 Missing ⚠️
src/visits/types/index.ts 0.00% 2 Missing and 1 partial ⚠️
...isits/visits-comparison/DomainVisitsComparison.tsx 60.00% 0 Missing and 2 partials ⚠️
...its/visits-comparison/ShortUrlVisitsComparison.tsx 66.66% 0 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   83.92%   83.73%   -0.19%     
==========================================
  Files         158      158              
  Lines        9057     9120      +63     
  Branches     1194     1200       +6     
==========================================
+ Hits         7601     7637      +36     
- Misses        288      311      +23     
- Partials     1168     1172       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/compare-visits-mercure branch from 3fd0b74 to b9eacf5 Compare January 17, 2024 08:01
@acelaya acelaya marked this pull request as ready for review January 17, 2024 18:33
@acelaya acelaya merged commit 5d1281a into shlinkio:main Jan 17, 2024
5 checks passed
@acelaya acelaya deleted the feature/compare-visits-mercure branch January 17, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow comparing visits for multiple short URLs, tags or domains
1 participant