Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash support does not work when the multi segment feature is enabled #1556

Closed
eleith opened this issue Sep 26, 2022 · 2 comments · Fixed by #1558
Closed

Trailing slash support does not work when the multi segment feature is enabled #1556

eleith opened this issue Sep 26, 2022 · 2 comments · Fixed by #1558
Labels
Milestone

Comments

@eleith
Copy link

eleith commented Sep 26, 2022

How Shlink is set-up

  • Shlink Version: 3.3.0

Summary

the trailing slash feature does not work when the multi segment feature is turned on

Current behavior

when SHORT_URL_TRAILING_SLASH is true, navigating to shortcode/ results in a 404 when MULTI_SEGEMENT_SLUGS_ENABLED is true and results in a proper redirect when false

Expected behavior

enabling both flags would turn on both features and they can co-exist

How to reproduce

  1. enable both flags
  2. create a short code (with no trailing slash)
  3. visit the short code with a trailing slash, get a 404
  4. disable multi path
  5. visit the short code with a trailing slash, get redirected
@eleith eleith added the bug label Sep 26, 2022
@acelaya acelaya added this to the 3.3.1 milestone Sep 27, 2022
@acelaya acelaya changed the title railing slash support does not work when the multi segment feature is enabled Trailing slash support does not work when the multi segment feature is enabled Sep 27, 2022
@acelaya
Copy link
Member

acelaya commented Sep 30, 2022

I have just released v3.3.1, which fixes this https://github.com/shlinkio/shlink/releases/tag/v3.3.1

@eleith
Copy link
Author

eleith commented Sep 30, 2022

excellent. your work and dedication are much appreciated. shlink is a testament to the value of constantly iterating and improving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants