Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace base abstract CLI command classes for param reusability, with value objects wrapping the logic #1563

Closed
acelaya opened this issue Oct 6, 2022 · 0 comments · Fixed by #1565
Closed

Replace base abstract CLI command classes for param reusability, with value objects wrapping the logic #1563

acelaya opened this issue Oct 6, 2022 · 0 comments · Fixed by #1565
Labels
tech debt
Milestone
3.4.0

Comments

@acelaya
Copy link
Member

acelaya commented Oct 6, 2022

The classes could also have a static method receiving a command to register the arguments.
@acelaya acelaya added this to the 3.4.0 milestone Oct 6, 2022
@acelaya acelaya mentioned this issue Oct 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
Shlink
Archived in project
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Feature/command reusable args acelaya-forks/shlink
1 participant
@acelaya