Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/address based tracking #1199

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 10, 2021

Closes #1104

@codecov-commenter
Copy link

Codecov Report

Merging #1199 (ceb642b) into develop (db98d81) will decrease coverage by 0.08%.
The diff coverage is 89.18%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1199      +/-   ##
=============================================
- Coverage      96.91%   96.82%   -0.09%     
- Complexity      1155     1166      +11     
=============================================
  Files            185      185              
  Lines           3657     3685      +28     
=============================================
+ Hits            3544     3568      +24     
- Misses           113      117       +4     
Impacted Files Coverage Δ
module/Core/src/Visit/RequestTracker.php 90.00% <85.18%> (-10.00%) ⬇️
module/Core/src/Options/TrackingOptions.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db98d81...ceb642b. Read the comment docs.

@acelaya acelaya merged commit f49e940 into shlinkio:develop Oct 10, 2021
@acelaya acelaya deleted the feature/address-based-tracking branch October 10, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disable tracking when a visit comes from an IP address previously defined
2 participants