Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default domain role #1384

Merged
merged 2 commits into from Feb 19, 2022

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 19, 2022

Closes #1378
Closes #1379

@codecov-commenter
Copy link

Codecov Report

Merging #1384 (7abe6af) into main (3e3d255) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1384   +/-   ##
=========================================
  Coverage     96.40%   96.41%           
- Complexity     1124     1127    +3     
=========================================
  Files           191      192    +1     
  Lines          3506     3512    +6     
=========================================
+ Hits           3380     3386    +6     
  Misses          126      126           
Impacted Files Coverage Δ
module/CLI/src/ApiKey/RoleResolver.php 100.00% <100.00%> (ø)
...e/CLI/src/Exception/InvalidRoleConfigException.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3d255...7abe6af. Read the comment docs.

@acelaya acelaya merged commit e1ebbaa into shlinkio:main Feb 19, 2022
@acelaya acelaya deleted the feature/default-domain-role branch February 19, 2022 18:42
@wfjsw
Copy link

wfjsw commented Feb 21, 2022

Is it possible to unset default domain so that all domains are treated equally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants