Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deferred geolite download #1548

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Sep 18, 2022

Closes #1528

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2022

Codecov Report

Merging #1548 (68e1c61) into develop (3f01fad) will decrease coverage by 0.01%.
The diff coverage is 92.15%.

@@              Coverage Diff              @@
##             develop    #1548      +/-   ##
=============================================
- Coverage      96.68%   96.67%   -0.02%     
- Complexity      1221     1234      +13     
=============================================
  Files            213      215       +2     
  Lines           3595     3611      +16     
=============================================
+ Hits            3476     3491      +15     
- Misses           119      120       +1     
Impacted Files Coverage Δ
...CLI/src/Command/Visit/DownloadGeoLiteDbCommand.php 96.15% <ø> (ø)
module/Core/src/Action/AbstractTrackingAction.php 100.00% <ø> (ø)
module/CLI/src/GeoLite/GeolocationDbUpdater.php 92.85% <76.92%> (ø)
...dule/CLI/src/Command/Visit/LocateVisitsCommand.php 96.77% <92.30%> (-0.15%) ⬇️
...Core/src/EventDispatcher/LocateUnlocatedVisits.php 100.00% <100.00%> (ø)
...odule/Core/src/EventDispatcher/UpdateGeoLiteDb.php 100.00% <100.00%> (ø)
.../Core/src/Exception/IpCannotBeLocatedException.php 100.00% <100.00%> (ø)
module/Core/src/Visit/VisitToLocationHelper.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acelaya acelaya marked this pull request as ready for review September 18, 2022 17:22
@acelaya acelaya merged commit 53b9e3d into shlinkio:develop Sep 18, 2022
@acelaya acelaya deleted the feature/deferred-geolite-download branch September 18, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postpone GetLite2 downloading task
2 participants