Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create migration for new rules and conditions tables #2022

Merged

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 24, 2024

Part of #1914

This PR adds a database migration, new entities and the entities persistence config, to persist rule-based redirection data.

Entities have a temporary shape, and will be polished when the business logic and API are implemented.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 97.11%. Comparing base (857c3a4) to head (6646232).
Report is 1 commits behind head on develop.

Files Patch % Lines
...Core/src/RedirectRule/Entity/RedirectCondition.php 0.00% 1 Missing ⚠️
...e/src/RedirectRule/Entity/ShortUrlRedirectRule.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2022      +/-   ##
=============================================
- Coverage      97.15%   97.11%   -0.05%     
- Complexity      1312     1314       +2     
=============================================
  Files            243      245       +2     
  Lines           4568     4570       +2     
=============================================
  Hits            4438     4438              
- Misses           130      132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya force-pushed the feature/redirect-rules-persistence branch from 059001f to 752100f Compare February 24, 2024 16:30
@acelaya acelaya marked this pull request as ready for review February 24, 2024 19:27
@acelaya acelaya merged commit 1a0fe04 into shlinkio:develop Feb 24, 2024
21 of 23 checks passed
@acelaya acelaya deleted the feature/redirect-rules-persistence branch February 24, 2024 19:27
@acelaya acelaya mentioned this pull request Feb 26, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant