Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to resolve the long URL to redirect to for a short URL #2024

Merged
merged 9 commits into from
Feb 26, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 24, 2024

Part of #1914

Closes #1902

Implement logic to dynamically redirect to different long URLs based on dynamic rules.

Also, implement logic specific to redirect dynamically based on query params, and partially for redirects based on accept language.

Todo:

  • Finish unit tests
  • Add E2E tests

@acelaya acelaya marked this pull request as draft February 24, 2024 22:10
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.17%. Comparing base (c5ddd83) to head (3284cea).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2024      +/-   ##
=============================================
+ Coverage      97.11%   97.17%   +0.06%     
- Complexity      1314     1327      +13     
=============================================
  Files            245      246       +1     
  Lines           4570     4609      +39     
=============================================
+ Hits            4438     4479      +41     
+ Misses           132      130       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya changed the title Create component to resolve the long URL to redirect to for a short URL Logic to resolve the long URL to redirect to for a short URL Feb 25, 2024
@acelaya acelaya marked this pull request as ready for review February 26, 2024 18:05
@acelaya acelaya mentioned this pull request Feb 26, 2024
8 tasks
@acelaya acelaya merged commit 89a987d into shlinkio:develop Feb 26, 2024
21 checks passed
@acelaya acelaya deleted the feature/rule-based-redirects branch February 26, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic redirects based on query parameters
1 participant