Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete expired #2086

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Apr 3, 2024

Closes #2059

Add a new short-url:delete-expired console command that can be used to delete short URLs that are considered "expired", because their validSince date is in the past, they reached the max amount of visits, or both.

image

@acelaya acelaya marked this pull request as ready for review April 3, 2024 17:20
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.01%. Comparing base (d090260) to head (4e10248).
Report is 3 commits behind head on develop.

❗ Current head 4e10248 differs from pull request most recent head b7db676. Consider uploading reports for the commit b7db676 to get more accurate results

Files Patch % Lines
.../src/ShortUrl/Model/ExpiredShortUrlsConditions.php 33.33% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2086      +/-   ##
=============================================
+ Coverage      95.99%   96.01%   +0.02%     
- Complexity      1379     1398      +19     
=============================================
  Files            256      259       +3     
  Lines           4941     5020      +79     
=============================================
+ Hits            4743     4820      +77     
- Misses           198      200       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit cc134ab into shlinkio:develop Apr 3, 2024
21 checks passed
@acelaya acelaya deleted the feature/delete-expired branch April 3, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow expired short URLs to be programmatically deleted
1 participant