WIP: Dynamic redirect rule based on IP #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This will be very helpful when implementing the feature. In the meantime, please, up-vote here #2101 (comment) I'll temporarily close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey !
I've worked on implementing the feature proposed in #2120.
I don't know if I've covered all the parts of the code where rules are handled, but I've added tests and I tested it manually after compiling the container, it handles properly.
I've tried my best to respect the coding standard of the project.
I'd gladly welcome feedback, and don't necessarily expect this to be merged, but maybe used as starting point for an upstream implementation.