Date filters for short urls list endpoint

[alesub]

These are new filters for the GET /rest/v1/short-urls endpoint. startDate and endDate are added as parameters to limit the results. It is useful to build reports on applications where the service has been running for several months.

Closes #575

[acelaya]

Cool! This will be really useful 😁

However, some changes are needed:

• This branch seems to be outdated. Conflicts need to be solved before merge is even possible.
• In most of the places, shlink makes use of Chronos objects instead of DateTimes. They are immutable and more flexible, so I would type hint to those any new date argument.
• The API always expects ISO dates in any other endpoint where a date can be provided, so I would also expect that format here, for consistency. It would also let more granular filtering than the Y-m-d format.
• Coding styles need to be fixed (usually GitHub triggers a build when a PR is created
  In this case it didn't happen. Maybe because of the conflicts? 🤔). In order to do it, it's usually enough to run composer cs:fix.
• Some tests need to be added (this is probably the most complex part). In this case we need database tests (they are basically integration tests which run against a real database covering repositories) and API tests (these are end-to-end tests running against real API endpoints).
• Open API docs need to be updated, including these two new arguments.

Of course, you can choose not to do any of those points, just do some of them, or do everything. I leave it up to you. I will finish what's missing 😀

And thanks again for the contribution!

[alesub]

Thanks for the feedback @acelaya, I'll see how much of this I can do and will let you know about any updates.

[alesub]

Hi @acelaya, I have applied all requests but the tests, if that's ok I'll leave the tests to you.

Please let me know about any comments,
Thanks!

[acelaya]

Amazing! Thanks for the hard work :)

If I remember correctly, github should allow me to push commits to your fork's branch, but if not, I will fork your fork :)

I will try to do it in the next days, in order to include this in v1.21

Changed applied

[alesub]

Sounds great, thanks to you for this great URL shortener @acelaya!

[acelaya]

Confirmed. Github lets me push to your fork. And build is back at green :)

[acelaya]

Just added all unit/database/api tests and fixed a couple of issues found in the process.

Tomorrow I will add support for these two new arguments to be passed to the short-url:list command, and then the PR will be ready to merge.

[alesub]

That's amazing, thanks!

[acelaya]

@alesub everything is ready now. You can review it if you want, but I'll probably merge it as soon as builds pass.

[acelaya]

I will also start working on shlink-web-client v2.3 after finishing shlink's v1.21 milestone, which will include controls to filter short URLs list by date, making use of this new implementation 😃

shlinkio/shlink-web-client#178

[alesub]

Amazing! Thanks!!