Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cors improvements #948

Merged
merged 3 commits into from
Dec 31, 2020

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Dec 31, 2020

Closes #877

@codecov-io
Copy link

Codecov Report

Merging #948 (9e7f2ae) into develop (202a732) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #948      +/-   ##
=============================================
- Coverage      97.71%   97.71%   -0.01%     
- Complexity       755      756       +1     
=============================================
  Files            133      133              
  Lines           2539     2538       -1     
=============================================
- Hits            2481     2480       -1     
  Misses            58       58              
Impacted Files Coverage Δ Complexity Δ
...dule/Rest/src/Middleware/CrossDomainMiddleware.php 100.00% <100.00%> (ø) 6.00 <1.00> (+1.00)
...Core/src/EventDispatcher/NotifyVisitToWebHooks.php 100.00% <0.00%> (ø) 7.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202a732...9e7f2ae. Read the comment docs.

@acelaya acelaya merged commit 09029df into shlinkio:develop Dec 31, 2020
@acelaya acelaya deleted the feature/cors-improvements branch December 31, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider dropping custom CorsMiddleware in favor of mezzio/mezzio-cors package
2 participants