Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confict in numbering of great moments in history #28

Closed
adnidor opened this issue Sep 12, 2018 · 2 comments
Closed

Confict in numbering of great moments in history #28

adnidor opened this issue Sep 12, 2018 · 2 comments

Comments

@adnidor
Copy link

adnidor commented Sep 12, 2018

fortune-mod/fortune-mod/datfiles/food

Line 232 in eeea808

GREAT MOMENTS IN HISTORY (#7): November 23, 1915

fortune-mod/fortune-mod/datfiles/science

Line 933 in 6c989cb

GREAT MOMENTS IN HISTORY (#7): April 2, 1751

Both fortunes have the same number (7) but a different content.

Solution would probably be to change one of the numbers.
@Pedro-Mendes
Copy link

Pedro-Mendes commented Oct 17, 2018 •
edited

I did a search on the whole folder from this repo and only found just 5 "GREAT MOMENT" quotes, is there a logical number for the id? I am wondering because as @adnidor said there are two '7's and there is a '21' from american history. How if there are only 5 quotes related to great moments?

Thanks!

shlomif added a commit that referenced this issue Dec 19, 2018
@shlomif
Normalize the numbers of "great moments".
bc90167 
See #28 . Thanks to
@adnidor and @Pedro-Mendes .
@shlomif
Copy link
Owner

shlomif commented Jan 12, 2019

Should be fixed and released - thanks!

@shlomif shlomif closed this as completed Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shlomif @adnidor @Pedro-Mendes