Correct GUID "isPermaLink" handling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you simplify the conditional as in my commit, and also provide a patch for the test suite as a regression test for this patch? |
|
Simplification of conditional done. I had not even looked at your tests, though now that I have, I see that the test's tests are in error. Give me a bit... |
|
Could I get a response on this? |
|
@dwmc15873 : sorry, but I wasn't notified on the extra commits on the pull request. Next time, please also post a comment. In any case, you may wish to take a look at this bug - https://rt.cpan.org/Public/Bug/Display.html?id=54135 and the appropriate SPEC, which I read as doing what you did here (I.e: the default is "true"). |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 27, 2016
Upstream changes:
1.58 2016-02-08
- Merge a pull-request regarding the handling of isPermaLink:
- shlomif/perl-XML-RSS#2
- Thanks to @dwmc15873 for the changes.
1.57 2015-12-13
- Update an old E-mail address for Shlomi Fish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the handling of 'isPermaLink' to adhere to both spec and
the comment above the actual test in code. New test returns '1' if
isPermalink is unset, or set to anything but 'false'.