Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/01ffo.t failure on Windows #2

Closed
jddurand opened this issue Dec 31, 2022 · 5 comments
Closed

t/01ffo.t failure on Windows #2

jddurand opened this issue Dec 31, 2022 · 5 comments

Comments

@jddurand
Copy link

Hello,

Using perl 5.37.6 on a Windows where symlink is supported but the user do not have the privilege to use it, the mentionned test fails:

t/01ffo.t ............. 1/4
#   Failed test 'Avoid loop warning'
#   at t/01ffo.t line 56.
#                   undef
#     doesn't match '(?^:\AAvoid loop (\S+) => \1\S+?link\r?\n?\z)'
# Looks like you failed 1 test of 4.

You might want to take a look at version 1.992_01 of Test::File that export a has_symlinks that correctly reports if symlink is supported, following issue briandfoy/test-file#36 .

I have a local patched version for File::Find::Object, c.f. attachement, but CPAN command refuses to upgrade to version 1.992_01 automatically. So take care with it: the t patch is ok IMHO, but the dependency change in the Makefile.PL fails for me. Anyway this is giving at least an idea of the origin of the issue: testing symlink alone is not enough, as per mention in https://perldoc.perl.org/perlport#symlink .

File-Find-Object-0.3.6-symlinks.patch

@shlomif
Copy link
Owner

shlomif commented Jan 1, 2023

@jddurand : hi. thanks. where can I find Test::File 1.993? it's not on cpanm / metacpan.

@jddurand
Copy link
Author

jddurand commented Jan 1, 2023

@jddurand : hi. thanks. where can I find Test::File 1.993? it's not on cpanm / metacpan.

@shlomif it should have been on cpan, uploaded december, 31th as per @briandfoy - though you I do not see it. I'll comment on briandfoy/test-file#36

@shlomif
Copy link
Owner

shlomif commented Jan 1, 2023

@jddurand - please try v0.3.7 .

@jddurand
Copy link
Author

jddurand commented Jan 2, 2023

Works with latest version of Test::File - many thanks.
What about adding

[Prereqs / TestRequires]
Test::File = 1.993

in dist.ini ?

@shlomif
Copy link
Owner

shlomif commented Jan 2, 2023

Works with latest version of Test::File - many thanks. What about adding

[Prereqs / TestRequires]
Test::File = 1.993

in dist.ini ?

no need4that - it is already detected. thanks.

@shlomif shlomif closed this as completed Jan 2, 2023
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jun 27, 2023
Add missing TEST_DEPENDS

Upstream changes:
0.3.7       2023-01-01
    - Fix test failures on mswin
        - shlomif/perl-file-find-object#2
        - thanks to @jddurand

0.3.6       2021-08-26
    - Extract https://metacpan.org/pod/File::TreeCreate .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants