remove extraneous arguments to use_ok #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra arguments to use_ok are arguments passed to the module's import method, not a test name. Newer perl versions will reject import calls with unhandled arguments, causing a failure.
|
On Fri, 21 Jul 2023 11:23:12 -0700 Graham Knop ***@***.***> wrote:
The extra arguments to use_ok are arguments passed to the module's import
method, not a test name. Newer perl versions will reject import calls with
unhandled arguments, causing a failure. You can view, comment on, or merge
this pull request online at:
#3
thanks! I'll try to take a look soon.
… -- Commit Summary --
* remove extraneous arguments to use_ok
-- File Changes --
M t/01ffo.t (2)
-- Patch Links --
https://github.com/shlomif/perl-file-find-object/pull/3.patch
https://github.com/shlomif/perl-file-find-object/pull/3.diff
--
Shlomi Fish https://www.shlomifish.org/
https://youtu.be/n6KAGqjdmsk - “Hurt Me Tomorrow”
95% of Programmers consider 95% of the code they did not write, in the bottom
5%.
— https://www.shlomifish.org/humour.html
Please reply to list if it's a mailing list post - https://shlom.in/reply .
|
|
@haarg : merged and released. thanks. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 16, 2023
0.3.8 2023-07-22
- Fix use_ok() call.
- shlomif/perl-file-find-object#3
- Thanks to @haarg .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extra arguments to use_ok are arguments passed to the module's import method, not a test name. Newer perl versions will reject import calls with unhandled arguments, causing a failure.