Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar and capitalisation. #2

Merged
merged 1 commit into from Mar 3, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES
Expand Up @@ -23,7 +23,7 @@ Revision history for HTTP::Recorder
- The showwindow option is gone (no popups any more).
- If you want to use the control panel, you need to start there.
- The control panel now spawns a window for navigation.
- The navigation window updates the Control Panel via Javascript.
- The navigation window updates the Control Panel via JavaScript.

Download button downloads the script file directly.

Expand Down
2 changes: 1 addition & 1 deletion README
Expand Up @@ -10,7 +10,7 @@ INSTALLATION

Set HTTP::Recorder as the agent for your web proxy.

Optionally, it uses javascript to open a window to display the script.
Optionally, it uses JavaScript to open a window to display the script.

PROBLEMS

Expand Down
22 changes: 11 additions & 11 deletions lib/HTTP/Recorder.pm
Expand Up @@ -11,15 +11,15 @@ HTTP::Recorder - record interaction with websites
=head2 This module is deprecated

It works by tagging links in a page, and then when a link is clicked
looking on the submitted tag to see which link was clicked
looking on the submitted tag to see which link was clicked.

It can not handle Javascript-created links or JS manipulation of the page
so it works only for fairly static websites
It can not handle JavaScript-created links or JavaScript manipulation of the
page so it works only for fairly static websites.

For better options check out Selenium
For better options check out Selenium.

Patchs are welcome, and I'll fix bugs as much as I can, but please don't
expect me to implement new features
Patches are welcome, and I'll fix bugs as much as I can, but please don't
expect me to implement new features.

=head2 Using HTTP::Recorder as a Web Proxy

Expand Down Expand Up @@ -72,7 +72,7 @@ start recording from the Control Panel.

=head3 Using the Control Panel

If you have Javascript enabled in your browser, go to the
If you have JavaScript enabled in your browser, go to the
L<HTTP::Recorder> control URL (http://http-recorder by default),
optionally type a URL into the "Goto page" field, and click "Go".

Expand Down Expand Up @@ -477,13 +477,13 @@ sub modify_response {
my $attrlist = @$token[3];
foreach my $attr (@$attrlist) {
# only rewrite if
# - it's not part of a javascript link
# - it's not part of a "javascript:" link
# - it's not a hidden field
$newcontent .= (" ".$attr."=\"".$attrs->{$attr}."\"");
}
$newcontent .= (">\n");
if ($tagname eq 'head') {
# add the javascript to update the script, right after the head opening tag
# add the JavaScript to update the script, right after the head opening tag
$newcontent .= $self->script_update();
}
if ($tagname eq 'form') {
Expand Down Expand Up @@ -720,9 +720,9 @@ EOF

=head1 Bugs, Missing Features, and other Oddities

=head2 Javascript
=head2 JavaScript

L<WWW::Mechanize> can't play back Javascript actions, and
L<WWW::Mechanize> can't play back JavaScript actions, and
L<HTTP::Recorder> doesn't record them.

=head2 Why are my images corrupted?
Expand Down