Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earley predict on complete input #109

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Earley predict on complete input #109

merged 1 commit into from
Sep 13, 2022

Commits on Sep 13, 2022

  1. Earley predict on complete input 

    An original (maybe overeager!) optimization was included with Earley
parsing. If there was no remaining input text, then no more predictions
from the grammar were attempted. In most cases, this saves Earley a
some work. But the BNF crate supports empty production
rules. This invalidates this optimization, because an empty production
may still be successful even with no remaining input text.

This commit only removes this optimization built on that false
assumption. It would be possible to reintroduce this improvement, but
*only* for grammars without any empty productions.
    @CrockAgile
    CrockAgile committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    e31217e View commit details
    Browse the repository at this point in the history