Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacker dependency optional (enabled by default) #121

Merged
merged 1 commit into from
Feb 4, 2023
Merged

stacker dependency optional (enabled by default) #121

merged 1 commit into from
Feb 4, 2023

Conversation

amascolo
Copy link
Contributor

@amascolo amascolo commented Feb 1, 2023

The stacker crate isn't strictly needed.

We may not wish to use it in production.

Also, its dependency psm doesn't support WASM.

It can be made optional (enabled by default).

@amascolo amascolo mentioned this pull request Feb 1, 2023
@CrockAgile
Copy link
Collaborator

This seems reasonable to me! stacker is only used for generation, which is only a part of BNF.

@CrockAgile CrockAgile merged commit 47e6803 into shnewto:main Feb 4, 2023
@coveralls
Copy link

Coverage Status

Coverage: 92.231% (+0.1%) from 92.114% when pulling ab24b96 on tably-team:main into f3ca021 on shnewto:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants