Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fiddle with coverage changes #141

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Fiddle with coverage changes #141

merged 2 commits into from
Dec 9, 2023

Conversation

CrockAgile
Copy link
Collaborator

@CrockAgile CrockAgile commented Dec 9, 2023 •
edited
Loading

Fiddled with some code to see if coverage reporting could improve, and also make some code a little cleaner, or remove unused code entirely

@CrockAgile CrockAgile self-assigned this Dec 9, 2023
@coveralls
Copy link

coveralls commented Dec 9, 2023 •
edited
Loading

Coverage Status

coverage: 97.956% (+1.3%) from 96.67%
when pulling 0a54ca3 on coverage-fun
into 67a7054 on main.

shnewto
shnewto approved these changes Dec 9, 2023
View reviewed changes
Copy link
Owner

@shnewto shnewto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! only thing better than a great benchmark setup is when things change as a result of benchmark work/results/findings

@CrockAgile CrockAgile merged commit 86c441a into main Dec 9, 2023
10 checks passed
@CrockAgile CrockAgile deleted the coverage-fun branch December 9, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shnewto shnewto shnewto approved these changes

Assignees

@CrockAgile CrockAgile

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CrockAgile @coveralls @shnewto