-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add autoconf and automake files #119
Conversation
* This adds more files to .gitignore. These are created when ./configure and make is run, and are removed when `make clean` or ` make distclean` is run.
Here's that link I forgot to include: https://www.gnu.org/software/gettext/manual/html_node/Adjusting-Files.html#Adjusting-Files |
VERSION will defined as a macro, and output to config.h when `./configure` is run. You'll want to #include config.h in bric.c, and you'll be able to use the macros that you desire later. Here's what my bric config.h looks like after running configure: ``` andy@oceanus:~/src/bric/src$ cat config.h /* src/config.h. Generated from config.in by configure. */ /* config.in. Generated from configure.ac by autoheader. */ /* Name of package */ /* Define to the address where bug reports for this package should be sent. */ /* Define to the full name of this package. */ /* Define to the full name and version of this package. */ /* Define to the one symbol short name of this package. */ /* Define to the home page for this package. */ /* Define to the version of this package. */ /* Version number of package */ ```
Oh this didn't render right when I added it to the commit message. Here's the correct output.
|
with commit b1403c6 , now you can actually see the build and install output: https://travis-ci.org/andy5995/bric/builds/420228519 Just click on one of the 4 jobs. And as you can see, the first one failed because of "undefined reference" problem. I'm not having that problem when building locally, and I'm using gcc 6.3.0 Let's wait until that's fixed to merge this. I'll give it some thought but if you have any ideas on how to fix that, let me know. |
Trying to fix the travis build at https://travis-ci.org/andy5995/bric/jobs/420228520
Ok, fixed by 79dadc7 and here's the output: https://travis-ci.org/andy5995/bric/builds/420234607 |
Hi Andy, This is an awesome PR - makes bric feel a lot more professional. I'm currently away for the weekend but I've just pulled my laptop out and built it and seems to work really well. I'll try explore the rest of the new configure script and the other file changes (aswell as reading those links) tonight but so far it looks really good. Also, thanks for integrating Travis! I haven't actually used it before so thanks for setting that up and showing me how it's done haha! |
You're welcome, Casey. Enjoy your weekend. Does bric have a development chat room on IRC or Slack or something like that? |
No I haven't really thought about setting one up actually. I'll do that now! Would probably be very useful if more people get involved. Edit: |
Cool. :) You'll want to make a note of this. Not a serious problem but users shouldn't see this. Only maintainers should have to worry about having "autoheader" installed. I'm trying to figure it out... I saw it wasn't a problem on travis. |
This prepares bric for adding support for GNU gettext (#109), a way for the program to get translated.
You can get an idea here from the gettext docs that these files are required to set up support for translation.
EDIT: https://www.gnu.org/software/gettext/manual/html_node/Adjusting-Files.html#Adjusting-Files
This PR will add a
configure
script, which allows for setting various options before runningmake
, including where bric would be installed to.I've removed the existing Makefiles; they are created when
configure
is run