Makes LocalizeController framework agnostic (see issue #8)
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see my response in this comment: #8 (comment) At this time, I’m not willing to remove compatibility with reactive controllers. If this PR fulfills your use case, I suggest forking the library and taking it that direction yourself. Sorry, I realize this is probably disappointing but I tried to comment as quickly as I could to save you the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@claviska Please have a look at the constructor of
LocalizeController. I think it should be clear what's the idea behind the changes.This is only an initial version, I have not even properly tested, but I think, something like this should do the job.
Please let me know if you are interested that I continue with this task.