Skip to content

Commit

Permalink
apply mutator to spritesheets
Browse files Browse the repository at this point in the history
  • Loading branch information
KonnorRogers committed Mar 15, 2024
1 parent 2a4b3ee commit 27c0cc8
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 2 deletions.
3 changes: 2 additions & 1 deletion docs/pages/resources/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti

- Added the Slovenian translation [#1893]
- Added support for `contextElement` to `VirtualElements` in `<sl-popup>` [#1874]
- Fixed a bug in `<sl-icon>` that did not properly apply mutators to spritesheets. [#]
- Fixed a bug in `.sl-scroll-lock` causing layout shifts. [#1895]
- Fixed a bug in `<sl-rating>` that caused the rating to not reset in some circumstances [#1877]
- Fixed a bug in `<sl-select>` that caused the menu to not close when rendered in a shadow root [#1878]
Expand Down Expand Up @@ -1731,4 +1732,4 @@ The following pages demonstrate why this change was necessary.

## 2.0.0-beta.1

- Initial release
- Initial release
15 changes: 14 additions & 1 deletion src/components/icon/icon.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,22 @@ export default class SlIcon extends ShoelaceElement {
let fileData: Response;

if (library?.spriteSheet) {
return html`<svg part="svg">
this.svg = html`<svg part="svg">
<use part="use" href="${url}"></use>
</svg>`;


// Using a templateResult requires the SVG to be written to the DOM first before we can grab the SVGElement
// to be passed to the library's mutator function.
await this.updateComplete

const svg = this.shadowRoot?.querySelector("[part='svg']") as SVGSVGElement

if (typeof library.mutator === "function") {
library.mutator(svg)
}

return this.svg
}

try {
Expand Down
4 changes: 4 additions & 0 deletions src/components/icon/icon.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,10 @@ describe('<sl-icon>', () => {
const rect = use?.getBoundingClientRect();
expect(rect?.width).to.equal(0);
expect(rect?.width).to.equal(0);

// Make sure the mutator is applied.
// https://github.com/shoelace-style/shoelace/issues/1925
expect(svg?.getAttribute("fill")).to.equal("currentColor")
});

// TODO: <use> svg icons don't emit a "load" or "error" event...if we can figure out how to get the event to emit errors.
Expand Down

0 comments on commit 27c0cc8

Please sign in to comment.