Skip to content

Commit

Permalink
fixes #1018
Browse files Browse the repository at this point in the history
  • Loading branch information
claviska committed Nov 21, 2022
1 parent 8f2a3bd commit 8b2c090
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/resources/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
- Improved `<sl-split-panel>` so the divider is visible in forced-colors mode
- Improved `<sl-tree-item>` so selected items are visible in forced-colors mode
- Improved `<sl-tab-group>` so tabs are cleaner and easier to understand in forced-colors mode
- Improved positioning of the menu in `<sl-select>` so you can customize the menu width [#1018](https://github.com/shoelace-style/shoelace/issues/1018)
- Moved all component descriptions to `@summary` to get them within documentation tools [#962](https://github.com/shoelace-style/shoelace/pull/962)
- Refactored form controls to use the `ShoelaceFormControl` interface to improve type safety and consistency
- Updated Lit to 2.4.1
Expand Down
2 changes: 1 addition & 1 deletion src/components/select/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ export default class SlSelect extends ShoelaceElement implements ShoelaceFormCon
<sl-dropdown
part="base"
.hoist=${this.hoist}
.placement=${this.placement}
.placement=${this.placement === 'bottom' ? 'bottom-start' : 'top-start'}
.stayOpenOnSelect=${this.multiple}
.containingElement=${this as HTMLElement}
?disabled=${this.disabled}
Expand Down

0 comments on commit 8b2c090

Please sign in to comment.