remove redundant role

shoelace-style · Nov 12, 2021 · a24eaa6 · a24eaa6
1 parent b98b10c
commit a24eaa6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md
@@ -8,6 +8,8 @@ _During the beta period, these restrictions may be relaxed in the event of a mis
 
 ## Next
 
+- Moved `role` from the shadow root to the host element in `<sl-menu>`
+- Removed redundant `role="menu"` in `<sl-dropdown>`
 - Slightly faster animations for showing and hiding `<sl-dropdown>`
 
 ## 2.0.0-beta.60

diff --git a/src/components/dropdown/dropdown.ts b/src/components/dropdown/dropdown.ts
@@ -425,7 +425,6 @@ export default class SlDropdown extends LitElement {
           <div
             part="panel"
             class="dropdown__panel"
-            role="menu"
             aria-hidden=${this.open ? 'false' : 'true'}
             aria-labelledby=${this.componentId}
           >

diff --git a/src/components/menu/menu.ts b/src/components/menu/menu.ts
@@ -26,6 +26,10 @@ export default class SlMenu extends LitElement {
   private typeToSelectString = '';
   private typeToSelectTimeout: any;
 
+  firstUpdated() {
+    this.setAttribute('role', 'menu');
+  }
+
   getAllItems(options: { includeDisabled: boolean } = { includeDisabled: true }) {
     return [...this.defaultSlot.assignedElements({ flatten: true })].filter((el: HTMLElement) => {
       if (el.getAttribute('role') !== 'menuitem') {
@@ -183,7 +187,6 @@ export default class SlMenu extends LitElement {
       <div
         part="base"
         class="menu"
-        role="menu"
         @click=${this.handleClick}
         @keydown=${this.handleKeyDown}
         @keyup=${this.handleKeyUp}