Skip to content

Commit

Permalink
remove ref attr
Browse files Browse the repository at this point in the history
  • Loading branch information
claviska committed Aug 18, 2021
1 parent 8c5dee5 commit fb48c4c
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 2 deletions.
1 change: 1 addition & 0 deletions docs/resources/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ This change applies to all design tokens that implement a color. Refer to the [c
- Exposed base and dark stylesheets so they can be imported via JavaScript [#438](https://github.com/shoelace-style/shoelace/issues/438)
- Fixed a bug in `sl-menu` where pressing <kbd>Enter</kbd> after using type to select would result in the wrong value
- Fixed a bug in `sl-radio-group` where clicking a radio button would cause the wrong control to be focused
- Fixed a bug in `sl-button` and `sl-icon-button` where an unintended `ref` attribute was present
- Improved contrast throughout all components [#128](https://github.com/shoelace-style/shoelace/issues/128)
- Refactored thumb position logic in `sl-switch` [#490](https://github.com/shoelace-style/shoelace/pull/490)
- Reworked the dark theme to use an inverted token approach instead of light DOM selectors
Expand Down
1 change: 0 additions & 1 deletion src/components/button/button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ export default class SlButton extends LitElement {
return isLink
? html`
<a
ref=${(el: HTMLLinkElement) => (this.button = el)}
part="base"
class=${classMap({
button: true,
Expand Down
1 change: 0 additions & 1 deletion src/components/icon-button/icon-button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export default class SlIconButton extends LitElement {
return isLink
? html`
<a
ref=${(el: HTMLLinkElement) => (this.button = el)}
part="base"
class="icon-button"
href=${ifDefined(this.href)}
Expand Down

0 comments on commit fb48c4c

Please sign in to comment.