-
-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete on Login doesn't work with sl-input type="password" #1205
Comments
Looking at the code it seems that for input type password it is always set to 'off'. Not sure why maybe there is a good reason behind it. @claviska
Also a quick read MDN (most browsers will still autocomplete it even if it is off) |
I remember adding this check for I've fixed that and also removed this check from the other two values, since they made it impossible to customize the values. This bug may affect the default values, but setting them to Fixed in 5b12de1. This will be available in the next releast. |
Great, thank you for fixing and explanation. 😄 |
I thought that it was because of the missing attribute. Maybe it has something to do with that Issue #1221. In Chrome autocomplete works just fine. Here is an Overview of my tests:
|
Sadly, I think that's exactly what it is. Please follow #1221 to track progress as things evolve. |
I have noticed a strange behavior with the sl-input type=password.
When I set the input with the autocomplete attribute, the same autocomplete attribute is added to the shadow root for other types.
But not with the type="password". Here the default is always set to "autocomplete=off" and so Safari key pass or Firefox don't fill the login data automatically.
I'm not quite sure if there is an actual bug, but I see that browsers don't recognize my sl-inputs as the native inputs
To Reproduce:
Set your password input in your login form to autocomplete="current-password"
After the first log in (and given password) the browser should ask for "Save password" and use it in future - this doesn't happen.
Screenshots
Here is an example of a login screen. The first email input is correct, also in the shadow root.
![sl-input](https://user-images.githubusercontent.com/46223359/220063249-ef425d8b-5c89-4e1b-918b-86b7b71f5f51.jpg)
The second password input is correct with autocomplete, but in the shadow root the attribute is not used.
Browser / OS
The text was updated successfully, but these errors were encountered: