Fixed clipped calendar toggle in Firefox #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the PR. To clarify, Firefox, no longer renders their own clear button now? Do we know when this changed? |
|
Yeah, it's no longer rendered. It was removed in Firefox 109 like mentioned here. If I read it right it will be re-added in the date picker panel instead in Firefox 112. Also in Version 110 they've added a shortcut to clear a date/time input. |
|
Looks great! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1212
This PR fixes that the calendar toggle gets clipped since Firefox 109. The reason for that is that the clear icon which was automatically added was removed. So the problem which we had before in #791 is solved so I removed the
clip-pathand the user agent sniff.