add touch functionality to rating component #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/shoelace/shoelace/BpWUUXJX2rFMQz68HZTjJUwtLxB1 |
|
Apologies, I kinda pulled the rug out from under you with the switch to LitElement. I think this has value for touch users, so would you mind updating this to the latest in Thanks! |
|
I'll look into it! |
|
That should be it. Thank's for putting the time into reading my pull request. |
|
This looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the rating component work on mobile as it does on desktop and feel more natural.
Currently the rating component only reacts to the click event on mobile.
By adding TouchStart (to imitate mouseEnter), TouchMove (MouseMove) and TouchEnd (MouseLeave), the rating component reacts to touch- as it does to mouse-event and, in my opinion, feels the way it should.
Let me know if this is not intended behavior or my code does not correspond to the project's standards.