Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify switch thumb position calc #490

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Simplify switch thumb position calc #490

merged 1 commit into from
Jul 28, 2021

Conversation

davidglezz
Copy link
Contributor

This is mathematically equivalent. This is possible because thumb-width === thumb-height

@vercel
Copy link

vercel bot commented Jul 28, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shoelace/shoelace/G1iinGPBh1cwZTWJYevMMCNhRHDE
✅ Preview: https://shoelace-git-fork-davidglezz-patch-1-shoelace.vercel.app

@davidglezz davidglezz changed the title Simplify switch thumb calc Simplify switch thumb position calc Jul 28, 2021
claviska
claviska approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks for the PR!

@claviska claviska merged commit b13e2c3 into shoelace-style:next Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claviska claviska claviska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidglezz @claviska