Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<sl-tab> not using border radius token #523

Closed
mcjazzyfunky opened this issue Sep 12, 2021 · 0 comments
Closed

<sl-tab> not using border radius token #523

mcjazzyfunky opened this issue Sep 12, 2021 · 0 comments
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@mcjazzyfunky
Copy link

mcjazzyfunky commented Sep 12, 2021

I guess, this line here

border-radius: 4px;

should be

 border-radius: var(--sl-border-radius-medium);

Looks a bit odd if you use a custom theme which prevents border-radius wherever reasonable, but still on the tabs you see a border radius of 4px.

[Edit] ... and this line here

should be:

 border-radius: var(--sl-border-radius-small);
@mcjazzyfunky mcjazzyfunky added the bug Things that aren't working right in the library. label Sep 12, 2021
@claviska claviska changed the title Minor CSS issue <sl-tab> not using border radius token Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants