Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent naming for font-size? #56

Closed
leesiongchan opened this issue Sep 16, 2017 · 1 comment
Closed

Consistent naming for font-size? #56

leesiongchan opened this issue Sep 16, 2017 · 1 comment
Labels
question General questions about the project.

Comments

@leesiongchan
Copy link

https://github.com/claviska/shoelace-css/blob/master/source/css/variables.css#L208

Currently we have font-size and font-size-small, do you think it makes sense to change them to:
font-size-sm, font-size-md, font-size-lg, etc. like you do for input (https://github.com/claviska/shoelace-css/blob/master/source/css/variables.css#L310)?
@claviska claviska added the question General questions about the project. label Sep 16, 2017
@claviska
Copy link
Member

Not at all. font-size is the base font size for the body, and font-size-small is intended specifically for the <small> element :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question General questions about the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@claviska @leesiongchan