Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner indicator not visible in Safari in beta 63 #633

Closed
jaredcwhite opened this issue Dec 27, 2021 · 3 comments
Closed

Spinner indicator not visible in Safari in beta 63 #633

jaredcwhite opened this issue Dec 27, 2021 · 3 comments
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@jaredcwhite
Copy link
Contributor

This is the first time I've seen the problem, not sure if it's only affected in beta 63. The animation seems to be working, but the actual indicator isn't showing, so it's just a static ring.

image

@jaredcwhite jaredcwhite added the bug Things that aren't working right in the library. label Dec 27, 2021
@claviska
Copy link
Member

Ha! I'm literally looking at this right now. I broke it when I simplified the animation. Safari is finicky with animating SVGs, but this time Firefox is also affected.

@claviska
Copy link
Member

This seems like a Safari bug. You should see a half circle in blue: https://codepen.io/claviska/pen/poWpPbY

Actual result in Safari:

CleanShot 2021-12-27 at 12 23 27@2x

Note that if you remove the track width (which is in pixels) from here it works: calc(50% - var(--track-width) / 2)

Perhaps Safari doesn't like [certain?] mixed units in stroke-dasharray. Both Chrome and Firefox render it correctly:

CleanShot 2021-12-27 at 12 23 08@2x

@claviska
Copy link
Member

I've simplified the math to use percentages. This makes it work in Safari, but it doesn't account for the track width. I think this is OK since it's only a matter of pixels and the indicator is animated anyways. It will only be noticeable with a large track width and a small radius, which doesn't really look good anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants