Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner animation broken in Safari browsers #1121

Closed
oliveratgithub opened this issue Jan 10, 2023 · 4 comments
Closed

Spinner animation broken in Safari browsers #1121

oliveratgithub opened this issue Jan 10, 2023 · 4 comments
Assignees
Labels
bug Things that aren't working right in the library.

Comments

@oliveratgithub
Copy link

Describe the bug

The sl-spinner animated progress is looping back and forth in Safari web-browsers (macOS and iOS). See video.

Demo

Upload.from.GitHub.for.iOS.MOV

Browser / OS

  • OS: macOS, iOS, iPadOS
  • Browser: Safari, Safari Mobile
  • Browser version: 16+

Additional information

Affects at least Shoelace versions 2.0.0-beta87 and 2.0.0-beta88

@oliveratgithub oliveratgithub added the bug Things that aren't working right in the library. label Jan 10, 2023
@oliveratgithub
Copy link
Author

Different issue that in earlier version, as described in #633

@CetinSert
Copy link

CetinSert commented Jan 10, 2023

The issue does not exist in .85.

  1. Go to https://sl.rt.ht/1121/?io
  2. Press 3 times to reach version .85

The above link also presents a faster way of loading Shoelace.

<!--
script src              REQ  TRANSFER
  /+esm              →    1   88.8 kB 
  /dist/shoelace.js  →  149  259.0 kB
-->

@claviska
Copy link
Member

This looks like a Safari bug. The regression occurred in 829e22d when changing transform: rotate(x) to rotate: x. Repro here:

https://codepen.io/claviska/pen/dyjvebY?editors=1100

I've reported this to the WebKit bug tracker:

https://bugs.webkit.org/show_bug.cgi?id=250387

In the meantime, reverting to translate: rotate(x) instead of rotate: x resolves it. I've also added a test to prevent this from happening again.

@claviska
Copy link
Member

Just a heads up that this has been fixed upstream in WebKit. https://bugs.webkit.org/show_bug.cgi?id=250387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

3 participants