-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<sl-dropdown>
cannot keep content in viewport (regression in 2.0.0-beta.81
)
#860
Comments
<sl-dropdown>
cannot push its content into viewport if its trigger is outside viewport (regression in 2.0.0-beta.81
)<sl-dropdown>
cannot push content into viewport if trigger is outside viewport (regression in 2.0.0-beta.81
)
@claviska – Here is a vertical example with video capture you can play right on this GitHub issue page! Please note that here, unlike above, the trigger is entirely in the viewport.
Here is a video capture that plays right on GitHub! Just click/tap on it 👇🏻 Sync.SL.860.and.32.more.pages.-.Personal.-.Microsoft.Edge.2022-08-18.21-10-03_Trim.mp4 |
<sl-dropdown>
cannot push content into viewport if trigger is outside viewport (regression in 2.0.0-beta.81
)<sl-dropdown>
cannot keep content in viewport due to a regression in 2.0.0-beta.81
<sl-dropdown>
cannot keep content in viewport due to a regression in 2.0.0-beta.81
<sl-dropdown>
cannot keep content in viewport (regression in 2.0.0-beta.81
)
Temporarily worked around with I have to say all this is really only possible and easy because of how well-designed Shoelace is! It truly is a gem of a library that shines bright among many that don't even grasp the power of web components, yet alone know what to do with the tech. 👟💎💖! Still looking forward to a solution on this one that works for everyone though : ) |
Replicated and fixed in 1996037. The |
Describe the bug
In version
.81
,<sl-dropdown>
cannot keep its content in viewport. This is a regression.One example is described here with a playground link and screenshots.
Another example is described in the next comment with a playground link and a video.
To Reproduce
Steps to reproduce the behavior:
Sync has versions selected for step 3 😉!
.81
.80
Demo
Demo is linked at step 1 above! Just open the link and press ↓ once! Simple as it gets.
Screenshots
.81
.80
Browser / OS
Additional information
.81
also taxes the CPU a lot more in this case!This seems to only happen with the right edge of the screen.See right below for a vertical reproduction with video!
RTL
mode.<sl-tooltip>
.1.0.1
.The text was updated successfully, but these errors were encountered: