Pressing ESC not working as expected with dialogs+popups

[xdev1]

Please open the following MUI demo:
https://mui.com/material-ui/react-dialog/#optional-sizes

Now click on the "OPEN MAX-WIDTH DIALOG" button and after that open the popup of the "maxWidth" select field. Now you have an opened dialog plus an opened popup at the same time.
Now press Escape => Result: The popup of the select field closes while the dialog stays open.
Now press Escape again => Result: The dialog closes.

I'd say, this is the expected behavior.
Now try the same with the following Shoelace demo:
https://codepen.io/xdev1/pen/WNyrjgE?editors=1000
Result: Both dialog AND popup will close immediately when you press Escape for the first time.

I personally think, this should be considered a bug in Shoelace and not just somehow be fixed in userland.

[claviska]

Agree. Thanks for reporting this!

[claviska]

Fixed in 5fd682d. This will be available in the next release.

[xdev1]

Unfortunately, this issue should be reopened, as this is still buggy.

Please open this demo, click on "Open dialog" and then click on the select box without selecting anything.
The popup is opened now. Then please press Escape => you'll see that the dialog will be closed immediately, instead of just closing the popup.

This change might do the trick:

[claviska]

@xdev1 Thanks for the update. The previous fix solved pressing Escape when the menu has focus. You discovered another edge case that occurred when the menu has focus.

I appreciate the report and the suggested fix! It was patched in 7f9b0bd and will be available in the next release.