Added title attribute #1043
Merged
Added title attribute #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also some other tests
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
requested changes
Nov 30, 2022
src/components/button/button.ts
Outdated
| @@ -98,6 +98,9 @@ export default class SlButton extends ShoelaceElement implements ShoelaceFormCon | |||
| /** An optional value for the button. Ignored when `href` is set. */ | |||
| @property() value = ''; | |||
|
|
|||
| /** The button's title attribute. */ | |||
There was a problem hiding this comment.
This isn't obvious, but the docs will ignore properties that don't have JSDoc comments like /**. We probably don't want to document this, since it's a global attribute. Instead, let's move these up closer to the private properties and change the comment so we know why we're adding them, e.g.
@property() title = ''; // make reactive to pass through
src/components/button/button.ts
Outdated
| @@ -255,7 +258,7 @@ export default class SlButton extends ShoelaceElement implements ShoelaceFormCon | |||
| })} | |||
| ?disabled=${ifDefined(isLink ? undefined : this.disabled)} | |||
| type=${ifDefined(isLink ? undefined : this.type)} | |||
| title=${'' /* An empty title prevents browser validation tooltips from appearing on hover */} | |||
| title=${this.title} | |||
There was a problem hiding this comment.
Can we preserve the comment? This will let folks know why we're setting a global attribute and help prevent regressions.
There was a problem hiding this comment.
Yeah, you're right. I preserved the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1042