fix form selection when element is detached (#1806) #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Should be fine. I would largely consider it an edge case tbh. Nothing should need to be adjusted for this. The type fix alone should catch us trying to do EDIT: As im diving into this more, a detached element with a form attribute actually never registers to the form. https://codepen.io/paramagicdev/pen/ZEPNpdp?editors=1111 Perhaps a check if the element is connected prior to checking the rootNode may be inline with regular HTML Elements. |
KonnorRogers
approved these changes
Feb 21, 2024
KonnorRogers
approved these changes
Mar 6, 2024
This was referenced May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1806 the problem is that
getElementById()only exists on document level butgetRootNode()returns a<div>because the button isn't attached to any document anymore.I don't know whether this fix is sufficient as it doesn't contain any escaping for the selector and also no adjusted tests.