Expose spinner part on tree item #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
reviewed
Mar 25, 2024
| @@ -257,7 +258,7 @@ export default class SlTreeItem extends ShoelaceElement { | |||
| })} | |||
| aria-hidden="true" | |||
| > | |||
| ${when(this.loading, () => html` <sl-spinner></sl-spinner> `)} | |||
| ${when(this.loading, () => html` <sl-spinner part="spinner"></sl-spinner> `)} | |||
There was a problem hiding this comment.
Thanks for the PR!
When exposing a part, we want to make sure we expose "sub-parts" too, so this needs something like exportparts="base:spinner__base" per these guidelines and another @csspart entry.
For reference, spinner parts can be found here.
claviska
approved these changes
Mar 25, 2024
|
@claviska Thank you for reviewing and releasing so fast! Appreciate it |
This was referenced May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other components that use the spinner (like button and menu item) expose the spinner part to allow for customisation. This just adds the same behaviour for the tree item.
My use-case for this is to customise the colour of the tree item spinner.