Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement roving tabindex for tabs #2041

Merged
merged 13 commits into from
May 30, 2024

Conversation

KonnorRogers
Copy link
Collaborator

@KonnorRogers KonnorRogers commented May 30, 2024

  • <sl-tab-group> now implements a proper "roving tabindex" and <sl-tab> is no longer tabbable by default. This aligns closer to the APG pattern for tabs.

https://www.w3.org/WAI/ARIA/apg/patterns/tabs/

Fixes #1744

Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview May 30, 2024 4:47pm

@KonnorRogers KonnorRogers changed the title Konnorrogers/implement roving tabindex tabs Implement roving tabindex for tabs May 30, 2024
src/components/tab-group/tab-group.test.ts Outdated Show resolved Hide resolved
@KonnorRogers KonnorRogers merged commit f256d7a into next May 30, 2024
2 checks passed
@KonnorRogers KonnorRogers deleted the konnorrogers/implement-roving-tabindex-tabs branch May 30, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Narrator is announcing Tab items present inside the 'Edit your manifest' dialogue as 'Group'.
2 participants